-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(firebaseai): Added support for Server Prompt Template #17767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces support for server-side templates in Firebase AI, including new model classes (TemplateGenerativeModel, TemplateImagenModel), API abstractions for template URIs, and a new example page to demonstrate the feature. The core logic seems well-structured and is accompanied by tests. My review includes a few points: a critical fix to remove a debug print statement, a high-severity bug fix in the new example page where user input was being ignored, and a low-severity suggestion to refactor some redundant code for better maintainability.
packages/firebase_ai/firebase_ai/example/lib/pages/server_template_page.dart
Show resolved
Hide resolved
packages/firebase_ai/firebase_ai/example/lib/pages/server_template_page.dart
Show resolved
Hide resolved
packages/firebase_ai/firebase_ai/lib/src/server_template/template_generative_model.dart
Outdated
Show resolved
Hide resolved
packages/firebase_ai/firebase_ai/lib/src/server_template/template_generative_model.dart
Outdated
Show resolved
Hide resolved
packages/firebase_ai/firebase_ai/lib/src/server_template/template_imagen_model.dart
Show resolved
Hide resolved
| } | ||
|
|
||
| /// Returns a [TemplateGenerativeModel] using its private constructor. | ||
| @experimental |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks internal?
| } | ||
|
|
||
| /// Returns a [TemplateImagenModel] using it's private constructor. | ||
| @experimental |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Internal?
Description
Add support for Server Prompt Templates.
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?